Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Modal can be instantiated multiple times #555

Closed
niktek opened this issue Nov 15, 2022 · 2 comments · Fixed by #565
Closed

Search Modal can be instantiated multiple times #555

niktek opened this issue Nov 15, 2022 · 2 comments · Fixed by #565
Labels
bug Something isn't working

Comments

@niktek
Copy link
Contributor

niktek commented Nov 15, 2022

Current Behavior

It's actually kinda cool :P But if you cmd-k you can bring up search, hit cmd-k again and a new instance overlays. Hitting escape will cancel the topmost one and re-init the underlying instance.

Steps To Reproduce

No response

Anything else?

No response
@niktek niktek added the bug Something isn't working label Nov 15, 2022
@endigo9740
Copy link
Contributor

endigo9740 commented Nov 15, 2022 •
edited

Oh boy, I knew we would have some trouble getting this in last minute. Whoops! Should be an easy fix at least.

@endigo9740
Copy link
Contributor

Fixing this alongside: #546

@endigo9740 endigo9740 mentioned this issue Nov 16, 2022
Merged
@endigo9740 endigo9740 linked a pull request Nov 16, 2022 that will close this issue
Fixed modal backdrop click bug, multiple search init bug #565
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed modal backdrop click bug, multiple search init bug skeletonlabs/skeleton
2 participants
@endigo9740 @niktek