You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
howdy folks, I just saw this new release of create-svelte (https://github.com/sveltejs/kit/releases/tag/create-svelte%402.0.0-next.191) pushed a couple of hours ago that now inlines style="display: contents" on the div that wraps %sveltekit.body% by default. I'm not sure if that would break anything when using App Shell since I haven't tried it out yet but I just wanted to give you guys a heads up
These elements don't produce a specific box by themselves. They are replaced by their pseudo-box and their child boxes. Please note that the CSS Display Level 3 spec defines how the contents value should affect "unusual elements" — elements that aren't rendered purely by CSS box concepts such as replaced elements. See Appendix B: Effects of display: contents on Unusual Elements for more details.
Due to a bug in browsers, this will currently remove the element from the accessibility tree — screen readers will not look at what's inside. See the Accessibility concerns section below for more details.
Current implementations in most browsers will remove from the accessibility tree any element with a display value of contents (but descendants will remain). This will cause the element itself to no longer be announced by screen reading technology. This is incorrect behavior according to the CSS specification.
Essentially we need to test the following:
Will this suffice instead of needing users to modify the app.html wrapping div styles for App Shell and general layouts?
If so, update the SvelteKit/Vite frameworks guides
Additionally, update the App Shell documentation.
Are you able to create a Pull Request with the fix?
Yes
The text was updated successfully, but these errors were encountered:
I've updated both the Frameworks > SvelteKit guide and the App Shell docs with this new recommendation. I didn't fix our app.html file, but it doesn't really matter. This new style doesn't really do much as far as I can tell.
Link to the Page
https://www.skeleton.dev/guides/frameworks/sveltekit
Describe the Issue
From user @cokakoala on Discord:
Per MDN:
https://developer.mozilla.org/en-US/docs/Web/CSS/display
MDN a11y concerns:
https://developer.mozilla.org/en-US/docs/Web/CSS/display#accessibility_concerns
Essentially we need to test the following:
app.html
wrapping div styles for App Shell and general layouts?Are you able to create a Pull Request with the fix?
Yes
The text was updated successfully, but these errors were encountered: