Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recommendation for Tailwind aspect-ratio plugin #571

Closed
endigo9740 opened this issue Nov 17, 2022 · 5 comments · Fixed by #588
Closed

Remove recommendation for Tailwind aspect-ratio plugin #571

endigo9740 opened this issue Nov 17, 2022 · 5 comments · Fixed by #588
Labels
documentation Improvements or additions to documentation

Comments

@endigo9740
Copy link
Contributor

Link to the Page

https://github.com/tailwindlabs/tailwindcss-aspect-ratio#compatibility-with-default-aspect-ratio-utilities

Describe the Issue

Tailwind CSS v3.0 shipped with native aspect-ratio support, and while these new utilities are great, the aspect-ratio property isn't supported in Safari 14, which still has significant global usage. If you need to support Safari 14, this plugin is still the best way to do that.

Safari 14 accounts for less than 2% of usage stats:
https://www.stetic.com/market-share/browser/

Tailwind should probably retire this one on their end TBH. But we'll do the next best thing for now.

Are you able to create a Pull Request with the fix?

Yes

@endigo9740 endigo9740 added the documentation Improvements or additions to documentation label Nov 17, 2022
@endigo9740 endigo9740 linked a pull request Nov 23, 2022 that will close this issue
@aunumever
Copy link

I'm still receiving this error when installing based on the docs.

@aunumever
Copy link

after adding this file: import '@skeletonlabs/skeleton/styles/all.css'

@Sarenor
Copy link
Contributor

Sarenor commented Mar 12, 2023

What error are you talking about?

@aunumever
Copy link

[plugin:vite:css] [postcss] /Users/.../client/node_modules/@skeletonlabs/skeleton/styles/elements/buttons.css:49:3: The `aspect-square` class does not exist. If `aspect-square` is a custom class, make sure it is defined within a `@layer` directive.

@endigo9740
Copy link
Contributor Author

endigo9740 commented Mar 14, 2023

@aunumever you realize you're posting this on a closed ticket where we removed support for this plugin. Which we removed because it no longer has a use case? Tailwind handles this natively as part of the core system.

Drop the plugin and use this:
https://tailwindcss.com/docs/aspect-ratio

In the future if you have an issue, create a new ticket. Posts like this are easy to miss. We will not respond here further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants