Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to button 'Gold Nouveau' on Themes page copy wrong code: #590

Closed
alexander-mart opened this issue Nov 24, 2022 · 2 comments · Fixed by #593
Closed

Click to button 'Gold Nouveau' on Themes page copy wrong code: #590

alexander-mart opened this issue Nov 24, 2022 · 2 comments · Fixed by #593
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@alexander-mart
Copy link

alexander-mart commented Nov 24, 2022

Click to button 'Gold Nouveau' on Themes page copy wrong code:

// as is:
import '@brainandbones/skeleton/themes/theme-gold nouveau.css';
// to be:
import '@brainandbones/skeleton/themes/theme-gold-nouveau.css';

Maybe, don't copy 'name', but 'url'?
But i'm not sure, because code that we see on L31 can't do that bug, i think.

navigator.clipboard.writeText(`import '@brainandbones/skeleton/themes/theme-${name.toLowerCase()}.css';`).then(

{ name: 'Gold Nouveau', colors: ['#e7c504', '#0697e5', '#cc1e8a'], surface: '#231631', url: `${presetUrl}/theme-gold-nouveau.css` },

@endigo9740
Copy link
Contributor

Good catch @alexander-mart we'll get that patched up. Thanks!

FYI @niktek if you're looking for low hanging items.

@endigo9740 endigo9740 added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Nov 24, 2022
@endigo9740 endigo9740 linked a pull request Nov 25, 2022 that will close this issue
@endigo9740
Copy link
Contributor

I've merged a fix for this. Thanks again @alexander-mart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants