Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SvelteKit 1.0 #676

Closed
endigo9740 opened this issue Dec 12, 2022 · 2 comments · Fixed by #723
Closed

Support SvelteKit 1.0 #676

endigo9740 opened this issue Dec 12, 2022 · 2 comments · Fixed by #723
Labels
administration Items related to the project but outside the code. enhancement New feature or request ready to test Ready to be tested for quality assurance.
Milestone
v1.0

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 12, 2022 •
edited

We're expecting the full v1.0 launch of SvelteKit this week. This may come with a number of notable improvements and breaking changes alongside this. So I'm creating this ticket to help capture these and ensure we apply changes to Skeleton asap.

Warning breaking changes may require hotpatches!

Update the core project to the v1.0 release! - DONE

Let's get the library and docs updated to use the stable v1.0+ release.

Vite 4.0 Launch - DONE

https://vitejs.dev/blog/announcing-vite4.html

@LukeHagar has notified us of some breaking related to CSS imports. I'll be reading through this post shortly to determine other notable changes.

image

End of support for Vite/Svelte and Astro

Per the above discussion and official Svelte CLI command, it seems that Vite + Svelte (without SvelteKIt) is being de-emphasized. Everything seems to be going to Vite + SvelteKit, which is what a standard SvelteKit project is. Given this, we may consider dropping our Vite-specific documentation, as the use case will be reduced mostly to users working in embedded application.

Per this discussion we've laid out our reasons for the change. The documentation will be updated to support two paths forward. This will target SvelteKit users only:

  1. CLI users
  2. Manual Installation - say when migrating within the context of an existing app (ex: Daisy -> Skeleton)
@endigo9740 endigo9740 added bug Something isn't working enhancement New feature or request labels Dec 12, 2022
@endigo9740 endigo9740 pinned this issue Dec 12, 2022
@endigo9740 endigo9740 changed the title Updates to support SvelteKit 1.0 Support SvelteKit 1.0 Dec 14, 2022
@endigo9740 endigo9740 modified the milestones: Post-v1.0, v1.0 Dec 14, 2022
@endigo9740 endigo9740 added administration Items related to the project but outside the code. and removed bug Something isn't working labels Dec 15, 2022
This was referenced Dec 15, 2022
Closed
Merged
@endigo9740 endigo9740 linked a pull request Dec 17, 2022 that will close this issue
Update documentation for SvelteKit only, remove Vite and Astro onboar… #723
Merged
@endigo9740 endigo9740 added the ready to test Ready to be tested for quality assurance. label Dec 17, 2022
@endigo9740
Copy link
Contributor Author

FYI a new PR has been setup with the documentation changes for CLI/Manual onboarding. See a preview here:
https://skeleton-docs-git-docs-sveltekit-only-onboarding-skeleton-labs.vercel.app/guides/install

I'll welcome feedback for a bit before this is merged.

@endigo9740
Copy link
Contributor Author

FYI the new docs have been merged

@endigo9740 endigo9740 unpinned this issue Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
administration Items related to the project but outside the code. enhancement New feature or request ready to test Ready to be tested for quality assurance.
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Update documentation for SvelteKit only, remove Vite and Astro onboar… skeletonlabs/skeleton
1 participant
@endigo9740