Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LocalStorageStore to lastest upstream release #677

Closed
endigo9740 opened this issue Dec 12, 2022 · 1 comment · Fixed by #695
Closed

Update LocalStorageStore to lastest upstream release #677

endigo9740 opened this issue Dec 12, 2022 · 1 comment · Fixed by #695
Assignees
Labels
enhancement New feature or request

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 12, 2022

The changelog is not super detailed but we want to maintain parity as possible.

Svelte Local Storage Store v0.3.2

These are the two projects in our project that will need to be updated:

These can be reference directly from the source

Just note we call our core function localStorageStore instead of writable per Josh's original source. Also make sure to keep the attribution at the top of our script.

@endigo9740 endigo9740 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 12, 2022
@endigo9740
Copy link
Contributor Author

And just in case anyone asks, the original source is MIT licensed and we obtained direct permission from Josh to include this:
joshnuss/svelte-persisted-store#104

@endigo9740 endigo9740 removed good first issue Good for newcomers help wanted Extra attention is needed labels Dec 15, 2022
@endigo9740 endigo9740 self-assigned this Dec 15, 2022
@endigo9740 endigo9740 linked a pull request Dec 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant