Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert an additional set Svelte Components to Element styles #756

Closed
4 tasks done
endigo9740 opened this issue Jan 2, 2023 · 5 comments · Fixed by #771
Closed
4 tasks done

Convert an additional set Svelte Components to Element styles #756

endigo9740 opened this issue Jan 2, 2023 · 5 comments · Fixed by #771
Assignees
Labels
enhancement New feature or request ready to test Ready to be tested for quality assurance.
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Jan 2, 2023

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!

None of these components contain logic, which makes them prime candidates to convert to Elements. That being CSS styles like buttons, badges, cards, etc rather than Svelte components. This greatly simplified the easy of use (no import needed).

  • Alerts
  • Breadcrumbs
  • Dividers
  • Gradient Headings

The first three would be a similar conversion to buttons, badges, cards, etc. But Gradient Headings would be a bit different. In most cases we would recommend folks generate their own @apply styles that are dropped into a reusable class in their global stylesheet. Something like this:

image

For now I'm opening this to feedback and questions, but plan to jump on this in the next few days.

What type of pull request would this be?

Enhancement

Any links to similar examples or other references we should review?

No response

@endigo9740 endigo9740 added the enhancement New feature or request label Jan 2, 2023
@endigo9740 endigo9740 self-assigned this Jan 2, 2023
@endigo9740 endigo9740 added this to the v1.0 milestone Jan 2, 2023
@endigo9740 endigo9740 changed the title Convert Alerts, Breadcrumbs, Dividers, Gradient Headings to Tailwind Elements Convert and additional set Svelte Components to Element styles Jan 3, 2023
@endigo9740 endigo9740 changed the title Convert and additional set Svelte Components to Element styles Convert an additional set Svelte Components to Element styles Jan 3, 2023
@endigo9740 endigo9740 pinned this issue Jan 3, 2023
@endigo9740
Copy link
Contributor Author

endigo9740 commented Jan 5, 2023

I'm working up a new PR for this. Currently the gradient heading will be slated for deprecation without replacement. I've provide a code snippet for how users can replicate this in their own project going forward.

Screen Shot 2023-01-05 at 12 42 31 PM

@endigo9740 endigo9740 linked a pull request Jan 5, 2023 that will close this issue
@endigo9740
Copy link
Contributor Author

endigo9740 commented Jan 5, 2023

Likewise the Divider component has received an deprecation warning, this will now point folks to the core.css documentation, which has been expanded to replicate all variations and styles.

Screen Shot 2023-01-05 at 1 25 51 PM

@endigo9740
Copy link
Contributor Author

Breadcrumbs are ready as well. These are nearly indistinguishable from the component and have a comparable amount of markup to implement.

Screen Shot 2023-01-05 at 2 24 45 PM

@endigo9740
Copy link
Contributor Author

Finally, Alerts elements have been created. I've also migrated all existing use of the Alerts component to use these. Including the messages shown in the screenshots in the prior posts above.

Screen Shot 2023-01-05 at 4 06 00 PM

@endigo9740 endigo9740 added the ready to test Ready to be tested for quality assurance. label Jan 5, 2023
@endigo9740 endigo9740 unpinned this issue Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to test Ready to be tested for quality assurance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant