Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer override all button classes on Paginator #934

Closed
knd775 opened this issue Feb 7, 2023 · 1 comment · Fixed by #935
Closed

Can no longer override all button classes on Paginator #934

knd775 opened this issue Feb 7, 2023 · 1 comment · Fixed by #935
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@knd775
Copy link
Sponsor Contributor

knd775 commented Feb 7, 2023

Current Behavior

When setting the buttonClasses prop on the Paginator component, btn-icon is not overridden, leading to styling issues with text more than a couple characters long.

Before 0.124.2:
before

After:
after

Steps To Reproduce

  1. Use paginator with buttonClasses and text labels for the buttons
<Paginator
  bind:settings={$tableStore.pagination}
  buttonClasses="btn variant-filled"
  buttonTextPrevious="Previous"
  buttonTextNext="Next"
  {disabled} /

Anything else?

No response

@knd775 knd775 added the bug Something isn't working label Feb 7, 2023
@endigo9740
Copy link
Contributor

endigo9740 commented Feb 7, 2023

FYI the fix is to move all instances of btn-icon from the inline HTML button classes, back up to the buttonClasses prop. I'd welcome a PR if someone can jump on this sooner than myself!

@endigo9740 endigo9740 added the help wanted Extra attention is needed label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants