Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed AppShell wrapper to a div and put the main tag around the pag… #725

Merged
merged 1 commit into from Dec 17, 2022

Conversation

brittneypostma
Copy link
Contributor

Closes: #724

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

Fixes the position of main tag.

Please briefly describe your changes here.

AppShell has a div wrapper now instead of main and main is wrapped around page content.

@vercel
Copy link

vercel bot commented Dec 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 10:25PM (UTC)

@endigo9740
Copy link
Contributor

Good catch, thanks @brittneypostma

@endigo9740 endigo9740 merged commit f1b2067 into skeletonlabs:dev Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppShell Component correct main positioning
2 participants