Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set cookie path for theme switcher to root #853

Merged
merged 1 commit into from Jan 19, 2023
Merged

Fix: Set cookie path for theme switcher to root #853

merged 1 commit into from Jan 19, 2023

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Jan 19, 2023 •
edited

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

Fixes #852

@vercel
Copy link

vercel bot commented Jan 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 4:07PM (UTC)

@endigo9740
Copy link
Contributor

@AdrianGonz97 Looks great, merging. Thanks!

@endigo9740 endigo9740 merged commit d836b22 into skeletonlabs:dev Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cookie path issue preventing theme switching
2 participants
@AdrianGonz97 @endigo9740