Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimizations #67

Open
kibertoad opened this issue Oct 12, 2022 · 3 comments
Open

Performance optimizations #67

kibertoad opened this issue Oct 12, 2022 · 3 comments

Comments

@kibertoad
Copy link
Contributor

kibertoad commented Oct 12, 2022

Having encountered performance degradation after introducing fastify-metrics, we've attempted doing some of the obvious performance optimizations.

Here are the results (benchmarks included):
kibertoad/fastify-prometheus-nitro#1

I'm not sending PR as-is because it is pretty intrusive, but I can replicate same or all of it in original repo if perf increase seems significant enough for you, and changes acceptable.

@SkeLLLa
Copy link
Owner

SkeLLLa commented Oct 13, 2022

Hi, since this plugin provide some utility functions the less if affects app performance, better it becomes. So any performance improvements are more than welcome.

@kibertoad
Copy link
Contributor Author

Awesome, I'll try to make a set of incremental PRs then.

@kibertoad
Copy link
Contributor Author

@SkeLLLa PR is up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants