Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update axios and fix default value for 'data' #277

Merged

Conversation

jhpedemonte
Copy link
Contributor

@jhpedemonte jhpedemonte commented Sep 29, 2021

  • Update axios to latest, in order to pick up vulnerability fix
  • Don't default to null for POST data, since axios will JSON.stringify that as "null" (instead of sending an empty payload, as before)

I verified locally with my app. When only updating axios to 0.21.4 (using yarn's resolutions feature), my app was broken as one of my POST requests was sending "null" as the payload body. With this PR, it's working as expected: an empty payload instead.

Fixes #276

@chakrihacker
Copy link
Collaborator

Looks good to me.
Thanks for the pr

@chakrihacker chakrihacker merged commit 4d4c45d into infinitered:master Oct 3, 2021
infinitered-circleci pushed a commit that referenced this pull request Oct 3, 2021
## [2.1.2](v2.1.1...v2.1.2) (2021-10-03)

### Bug Fixes

* update axios and fix default value for ([#277](#277)) ([4d4c45d](4d4c45d))
@infinitered-circleci
Copy link

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to axios 0.21.4 to pick up vulernability fix
3 participants