Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake8 on pre-commit hook doesn't catch some errors #132

Closed
refacktor opened this issue Aug 12, 2022 · 0 comments · Fixed by #136
Closed

flake8 on pre-commit hook doesn't catch some errors #132

refacktor opened this issue Aug 12, 2022 · 0 comments · Fixed by #136
Labels
technical debt Code refactoring, not tied to performance or functionality

Comments

@refacktor
Copy link
Collaborator

For example, the fix in commit 0ae787a:

The parent commit throws an E275 in the github flake8 action.

Running locally as part of commit or with pre-commit run --all-files does not produce any error.
@refacktor refacktor added the technical debt Code refactoring, not tied to performance or functionality label Aug 12, 2022
@refacktor refacktor mentioned this issue Apr 25, 2023
Merged
@refacktor refacktor linked a pull request May 1, 2023 that will close this issue
emergency fixes to revive skepticoin #136
Merged
@lk16 lk16 closed this as completed in #136 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt Code refactoring, not tied to performance or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

emergency fixes to revive skepticoin kryptocurrency/skepticoin
1 participant
@refacktor