-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestsInTestFolder
is over-agressive
#21
Comments
Hi @halostatue! Not sure I'm following, |
It took me a bit to recall what I meant from months ago. However, it should not be incorrect to have |
Ah I see what you mean! Yes that is correct, we should indeed be checking for the first part of the path only 👍 |
The main question would be whether |
yep, true that, I'll poke around 😸 |
This check asserts the whether
"lib" in Path.split(source_file.filename)
is true. However, this is finding cases like:test/lib/context/employees_test.exs
, which is technically correct (and indicates that the test probably belongs in a different folder), but is not correct because the test is under thetest/
folder.It seems to me that the condition should be that a test file is, first and foremost, found outside of the
test/
directory, or if that’s not preferred, that there’s a second check to make sure that the file’s path doesn’t begin withtest/
.The text was updated successfully, but these errors were encountered: