Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style: need lint rules #35

Closed
plrthink opened this issue Oct 28, 2016 · 3 comments
Closed

Code Style: need lint rules #35

plrthink opened this issue Oct 28, 2016 · 3 comments

Comments

@plrthink
Copy link

Perhaps we need some lint rules to ensure the code style?

@mossyblog
Copy link

mossyblog commented Oct 31, 2016

  • Keep in mind this is taking a dependency on code outside the ES6 / Node modules. Therefore the entire ruleset will need fair amount of setup work to overcome expectations. Already I'm seeing the globals having "ignore" rules just for no-undef same goes with new-cap (ie NSColor, MSPage, MSDocument all break a set of rules in all eslint standards)
  • These rules will need to be transportable to the community as well to ensure every ones boats are able to rise with the same tide (as in the .eslintrc.js will need to also be versioned).
  • One would need to also ensure a healthy "setup" wiki is kept up to date in order to ensure everyone who contributes or builds standard "plugins" can achieve parity without frustration.
  • One would also need to weigh up how acceptable sprinkling code like /*eslint new-cap: ["error", { "newIsCap": true }]*/ vs // eslint-disable-next-line no-use-before-define vs global config is fair game?

@mossyblog
Copy link

mossyblog commented Nov 1, 2016

I've implemented eslint using Standard as the chosen format / guidelines. #36 has the current working code up to parity with 0 issues.

@mathieudutour
Copy link
Contributor

fixed in #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants