Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist node built-in packages #247

Closed
thangngoc89 opened this issue Aug 3, 2019 · 1 comment
Closed

Whitelist node built-in packages #247

thangngoc89 opened this issue Aug 3, 2019 · 1 comment
Labels
e/bucklescript Bucklescript engine related issues good first issue Good for newcomers P/3 Nice to have. No immediately need to deal with it right away
Milestone
Bucklescript offi...

Comments

@thangngoc89
Copy link
Member

There aren't anyway to differentiate between a node built-in packages versus a npm package. So we need a whilelist with browser compatible version of it.

crypto -> crypto-browserify
@thangngoc89 thangngoc89 added good first issue Good for newcomers e/bucklescript Bucklescript engine related issues P/3 Nice to have. No immediately need to deal with it right away labels Aug 3, 2019
thangngoc89 added a commit that referenced this issue Aug 4, 2019
@thangngoc89
fix(bs): Mapping commonjs pkg to browserify
047b35f 
close #247
@thangngoc89
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e/bucklescript Bucklescript engine related issues good first issue Good for newcomers P/3 Nice to have. No immediately need to deal with it right away
Projects
None yet
Milestone
Bucklescript official release
Development

No branches or pull requests
1 participant
@thangngoc89