Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune sound algorithm #9

Open
skewyapp opened this issue Oct 30, 2022 · 2 comments
Open

Fine tune sound algorithm #9

skewyapp opened this issue Oct 30, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@skewyapp
Copy link
Owner

skewyapp commented Oct 30, 2022

Task
[x] Evaluate feasibility
[ ] Check for feasible increments of volume
[ ] Add slider for volume
[ ] Add color code on slide for "too little" and "too much"

Background

  • Give more user flexibility for fine tuning
  • User request in reviews (Str8 Talknewfone)
  • A slider can actually show the user whether sound is on
  • Since the ultrasonic jam is played at the volume setting, this is important user feedback
  • User can turn on jamming, but if his volume is set to 0, jamming will not work

Result
tba

@skewyapp skewyapp added the enhancement New feature or request label Oct 30, 2022
@skewyapp skewyapp added this to the Release 8.0 milestone Dec 18, 2022
@skewyapp
Copy link
Owner Author

skewyapp commented Dec 18, 2022

The way to display it is either below the switch play or next to it.
It either breaks the alignment of the slider (next to it) or occupies a lot of space (below it).

Below
Bild_2022-12-18_132502113

Bild_2022-12-18_132651457

Next to it
Bild_2022-12-18_132630741

Bild_2022-12-18_132732614

Current choice is next to it, as the techncial advantage outweighs the visual one.

@skewyapp skewyapp removed this from the Release 8.0 milestone Dec 19, 2022
@skewyapp
Copy link
Owner Author

Code for layout. Since the time to figure out how to change the track background colour is too long. This will not be included in the coming release.

 <com.google.android.material.slider.Slider
        android:id="@+id/slider_volume"
        android:layout_width="240dp"
        android:layout_height="8dp"
        android:stepSize="2"
        android:valueFrom="0"

        android:valueTo="100"
        android:layout_marginStart="16dp"
        app:layout_constraintStart_toEndOf="@id/switch_play"
        app:layout_constraintTop_toTopOf="@id/switch_play" />

@skewyapp skewyapp added this to the Release 9.0 milestone Dec 22, 2022
@skewyapp skewyapp removed this from the Release 9.0 milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant