[MRG] put black dependency as optional #120
Conversation
setup.py
Outdated
| @@ -71,6 +71,7 @@ | |||
| 'inverse_covariance.profiling', | |||
| 'inverse_covariance.pyquic'], | |||
| install_requires=INSTALL_REQUIRES, | |||
| extras_require=dict(contribute=['black==18.6b4']), | |||
There was a problem hiding this comment.
maybe instead of "contribute" something like "style" ?
|
I checked and with this modification the install works with python2.7 |
|
I think the right thing to do here is split out the dev requirements into a separate file as I've done here: https://github.com/jasonlaska/spherecluster |
|
That's nice, something like this ? |
.travis.yml
Outdated
| @@ -27,6 +27,7 @@ install: | |||
|
|
|||
| # command to run tests | |||
| script: | |||
| - pip install black | |||
There was a problem hiding this comment.
Instead of this, change line 25 to install the dev-requirements
There was a problem hiding this comment.
(the dev requirements are a superset of the requirements so you should only need to reference the one file)
There was a problem hiding this comment.
Side note: since this version of black isn't tied to the version in dev-requirements, the tests fail (Black makes minor breaking changes to formatting in each version).
There was a problem hiding this comment.
Ah yes, indeed, thanks !
|
Minor comment about the travis script, but yes, this is good. |
|
LGTM, I think the tests are breaking due to a non-deterministic bug. |
|
Thank you @wdevazelhes for your contribution. |
|
Is it possible to deploy a release to PyPI to include this update? |
Fixes #119
I couldn't install
skggmwith python2.7 because black does not seem to exist in python 2.7 (see https://github.com/ambv/black#installation). I thought this could be a fix (puttingblackas an optional dependency), but I may be totally wrong here