Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Rendering Styled Controls and GlobalUseSkia= true #217

Closed
TheOriginalBytePlayer opened this issue Apr 1, 2023 · 5 comments
Closed

Comments

@TheOriginalBytePlayer
Copy link

TheOriginalBytePlayer commented Apr 1, 2023

See Attached Project Sample
FMXStyleRenderBug.zip

With GlobalUseSkia = True you'll see that the progress bar never shows its bar, AND the track bar's track is empty in addition to it having an empty, non-filled circle for the thumb.
image

With GlobalUseSkia =FALSE, it displays as expected, both the progress bar AND Track bar's thumb and track are correct.
image

My guess is that this has something to do with gradient fills in the style sheets...

@TheOriginalBytePlayer
Copy link
Author

Bump?

@MyBuzzTechnologies
Copy link

I've just noticed this on a TRectangle with gradient fill since updating to Skia4Delphi 5.0.0.
This is on an FMX project and affects Windows, iOS and Android builds.

Reproduce:

  1. Create a new Multi Device project (FMX)
  2. Add a TRectangle. Set Fill.Kind to Gradient
  3. Run it and it looks ok
  4. Right-click the project, choose Enable Skip
  5. Run the project again. The rectangle now appears empty

100% reproducible on all platforms.
Could you please look into this ASAP as it's a big issue for apps like ours that use gradients which no longer show at all.

@checkdigits
Copy link

Thanks for letting us know. I'll see if this can get looked at ASAP. I've raised a message in the Telegram group too although here in GitHub is the best place for bugs.

@alexdgs
Copy link

alexdgs commented May 5, 2023

Well, not sure if this will work for anyone else but I found the following workaround for a FMX project:

  • Copy file Skia.FMX.Graphics.pas from Skia installation to Delphi project.
  • Locate procedure TSkCanvasCustom.BeginPaint (line 1407), and at the very beginning change FPaint.Alpha := 0 to FPaint.Alpha := 255.

After compilation gradients are painted correctly. The project I tested this is very simple so I'm unaware of any side effects this could have on more complex scenarios.

@paulocesarbot
Copy link
Collaborator

Fixed on new version 6.0.0-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

5 participants