Problems rendering many SVG Images

[carloBarazzetta]

First of all I want to congratulate you on the excellent work done with version 3.
While I was integrating it into the SVGIconImageList project, I noticed several rendering problems of SVG images, maybe I am doing something wrong in the implementation but I also tried with your demo using a different file from "gorilla" and it doesn't work.
I am attaching a zip containing a series of SVG files that are not fully or partially rendered.
svg_examples.zip
Thank you.

[viniciusfbb]

Hi @carloBarazzetta, thank you so much for reporting the issue!

I tested a lot of SVGs and the problem I encountered was just the lack of built-in css (style element) support. However, the ones you sent have one more problem that I just discovered, the doctype!

Everything works when removing the line:

<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" [
  <!ENTITY ns_svg "http://www.w3.org/2000/svg">
  <!ENTITY ns_xlink "http://www.w3.org/1999/xlink">
]>

It's clearly a bug. I will report to the official skia channel.

A good site to discover these issues is https://jakearchibald.github.io/svgomg/. With it it is possible to adjust several types of different configurations for the svg file and go testing.

[viniciusfbb]

But let's investigate further to see what can be done.

[carloBarazzetta]

Thank you very much!

[paulocesarbot]

Entity processing has been disabled to inhibit internal entity expansion for security reasons.

You can get more information: https://www.cve.org/CVERecord?id=CVE-2013-0340

You can see on Skia source src/xml/SkXMLParser.cpp:

// Disable entity processing, to inhibit internal entity expansion. See expat CVE-2013-0340.
XML_SetEntityDeclHandler(ctx.fXMLParser, entity_decl_handler);

Whenever there is an entity parse is stopped.

We will close the issue but we will document and keep an eye out for any changes.

@carloBarazzetta thank you so much for reporting! We will document and add instructions and description about the case!