Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing SVG files without DOCTYPE ENTITY content #43

Closed
carloBarazzetta opened this issue Feb 14, 2022 · 4 comments
Closed

Error parsing SVG files without DOCTYPE ENTITY content #43

carloBarazzetta opened this issue Feb 14, 2022 · 4 comments

Comments

@carloBarazzetta
Copy link

playing-cards.zip
flags.zip
Hi guys, I've attached another series of SVG images with rendering problems...
Thank you.
Carlo

@viniciusfbb
Copy link
Member

@carloBarazzetta First of all, thank you so much again for reporting an issue! This makes the library even better.

Regarding the case, this is another limitation of Skia. It does not yet support inner <symbol> elements. We believe that in a short time these limitations will disappear, as Flutter also from Google uses the same module for rendering SVGs. In any case, it is an extremely fast and stable parser, despite the limitations. In fact, in a benchmark we did, it was faster than Image32, D2D and Cairo.

I apologize in advance for not documenting it sooner. We tested it with thousands of app icon svgs (using top SVG icon sets, like, Bootstrap Icons, Font Awesome Icons, Material Design Icons by Google, Octicons by Github) and all rendered perfectly.

@carloBarazzetta
Copy link
Author

Thanks @viniciusfbb, I also did some performance tests and SKIA is very fast, I can't wait to be able to use it with my components and with most of the SVG files available!

@carloBarazzetta
Copy link
Author

Sorry for my error regarding SVG's contained into flags.zip: those files works perfectly with SKIA4Delphi, I've made an error implementing support for SVGIconImageList, now fixed.

@viniciusfbb
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants