Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Type-safe" is a confusing name #10

Closed
vprudnikov opened this issue Jan 8, 2024 · 5 comments
Closed

"Type-safe" is a confusing name #10

vprudnikov opened this issue Jan 8, 2024 · 5 comments

Comments

@vprudnikov
Copy link

vprudnikov commented Jan 8, 2024

Hi!

Could you please consider renaming a "type-safe" builder to something else like "step builder" or "fluent builder"?
I'm asking about this since the "type-safe builder" is a bit confusing and usually means something different like https://kotlinlang.org/docs/type-safe-builders.html

More links:

So, while all the concepts may seem overlapping, "type-safe builder" is a broader term encompassing any builder pattern that uses the type system to enhance safety. In contrast "step builder" is a specific implementation style within the builder pattern.

@skinny85
Copy link
Owner

Hi @vprudnikov, thanks for opening the issue. I agree that, judging from this Twitter thread (and the various documentation links contained in it), it seems like the community has settled on using "Staged" for the name of this concept.

I'll add BuilderStyle.STAGED as a synonym for BuilderStyle.TYPE_SAFE, and I'll update the docs to use the "Staged" vocabulary instead of "type safe".

@vprudnikov
Copy link
Author

@skinny85 , thanks for the response!
An answer given by ChatGPT:
image

Although I admit that I maybe asked it a wrong question :)

@skinny85
Copy link
Owner

@vprudnikov This is now done on the develop branch. You can see the updated documentation in the ReadMe file here.

If everything looks good, I'll include these changes in the next release, that will also contain fixes for #5 and #11.

@vprudnikov
Copy link
Author

@skinny85 , looks great! Thanks!

@skinny85
Copy link
Owner

This has been fixed in the latest Jilt release (1.4).

I'm closing this issue as "Resolved", please comment if you run into any more problems related to this area, and I'll reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants