Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planet-unique data is incorrectly cached #17

Closed
skiwi2 opened this issue Jan 8, 2016 · 0 comments
Closed

Planet-unique data is incorrectly cached #17

skiwi2 opened this issue Jan 8, 2016 · 0 comments
Labels
Milestone

Comments

@skiwi2
Copy link
Owner

skiwi2 commented Jan 8, 2016

Data that is unique for every planet (Defences, Fleet, Shipyard, Buildings, etc.) is currently cached per player via executeIfNotCached which uses getFullCacheKey, which in turn uses getSetting which uses getFullSettingsKey which uses the server group, universe id, player id and the key.

This means that if two planets have the same data, they will not get updated correctly.

As solution the planetId should be included in the cache key, additionally a new mechanism should be used to delete all cached settings when changing the OGNext instance URL.

@skiwi2 skiwi2 added the bug label Jan 8, 2016
@skiwi2 skiwi2 added this to the v0.3 milestone Jan 8, 2016
@skiwi2 skiwi2 closed this as completed in 531022a Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant