Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudKit sync #113

Open
skjiisa opened this issue Oct 15, 2020 · 1 comment
Open

Add CloudKit sync #113

skjiisa opened this issue Oct 15, 2020 · 1 comment
Labels
feature New feature to be added wontfix This will not be worked on

Comments

@skjiisa
Copy link
Owner

skjiisa commented Oct 15, 2020

The difficult part of this is going to be not having duplicates of the preloaded data.

If CloudKit syncs before data is preloaded, then this shouldn't be too big of an issue, as the data preload will simply reference the existing objects. It will override it though, so if the user changed any of it it'll revert back to default.

If this is how this works, this could be remedied by checking if there is data already before preloading. Updates would then have to be handled differently though, having a new internal JSON file per update. That maybe should be how it's done anyway though.

If the preload is run before the CloudKit sync then you'll likely end up with duplicate entries every time you install the app on a new device.

@skjiisa skjiisa added the feature New feature to be added label Oct 15, 2020
@skjiisa skjiisa added this to the v1.3 milestone Oct 15, 2020
@skjiisa skjiisa removed this from the v1.3 milestone Jul 31, 2021
@skjiisa
Copy link
Owner Author

skjiisa commented Jul 31, 2021

I actually don't think there's much of a reason to add this. I think being able to export characters and maybe do bulk exports would be enough and could potentially even be better than iCloud sync.

@skjiisa skjiisa added the wontfix This will not be worked on label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to be added wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant