Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renamed compiled files #174

Closed
MichaIng opened this issue Jul 18, 2021 · 1 comment
Closed

Remove renamed compiled files #174

MichaIng opened this issue Jul 18, 2021 · 1 comment

Comments

@MichaIng
Copy link

Compiled files in apps/settings/js/ with a hash in their filename are added by npmbuildbot, but the original obsolete files are not removed. E.g.:

apps/settings/js/vue-settings-apps-07e8cbec2ce050decc48.js → apps/settings/js/vue-settings-apps-47d9744236537ed568e3.js

In such case, currently the original file needs to be removed manually.

To reduce manual efforts and load from drone and check servers, it would be great if the bot removed old files before adding new ones. The GitHub action does make clean for that (?): https://github.com/nextcloud/server/blob/c42385e/.github/workflows/node.yml#L27
I guess git rm apps/settings/js, followed by build and then git add apps/settings/js would work as well, as all included files are rebuilt?

@MichaIng
Copy link
Author

Obsolete as those hash suffixes are not added anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant