Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for overloading and the params keyword. #20

Closed
fadulalla opened this issue Oct 25, 2018 · 1 comment
Closed

Added support for overloading and the params keyword. #20

fadulalla opened this issue Oct 25, 2018 · 1 comment
Assignees
@sklose
Labels
enhancement

Comments

@fadulalla
Copy link
Contributor

Enhancement
Hey!

I needed support for overloading and the params keyword so I went ahead and added them in a fork.
I opened a PR in case others have similar needs, here: #19 ..

I am not sure if I was meant to open an issue before creating a PR, so here's an issue, just in case.
@fadulalla fadulalla mentioned this issue Oct 25, 2018
Merged
@sklose sklose self-assigned this Oct 27, 2018
@sklose
Copy link
Owner

sklose commented Oct 27, 2018

Hi fadulalla,

thanks for your contribution, that's a very neat feature to have. I just merged your PR. A new version with the feature should be published shortly by the build system.

-Sebastian

@sklose sklose closed this as completed Oct 27, 2018
@fadulalla fadulalla mentioned this issue May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklose sklose

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sklose @fadulalla