Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 getOperationsList issue #37

Closed
fhempy opened this issue Sep 4, 2021 · 11 comments
Closed

1.1.0 getOperationsList issue #37

fhempy opened this issue Sep 4, 2021 · 11 comments

Comments

@fhempy
Copy link
Contributor

fhempy commented Sep 4, 2021

Hi,

unfortunately I get the following error with 1.1.0

2021-09-04 09:09:06,434 - ERROR    - skodaconnect.connection: Got HTTP 400 400, message='Bad Request', url=URL('https://msg.volkswagen.de/api/rolesrights/operationlist/v3/vehicles/xxxxxxxxxx')"Bad Request" from server, this request might be malformed or not implemented correctly for this vehicle

I couldn't get the root cause of this one, maybe it has something to do with the new token handling?

@Farfar
Copy link
Collaborator

Farfar commented Sep 4, 2021

Hi,

unfortunately I get the following error with 1.1.0

2021-09-04 09:09:06,434 - ERROR    - skodaconnect.connection: Got HTTP 400 400, message='Bad Request', url=URL('https://msg.volkswagen.de/api/rolesrights/operationlist/v3/vehicles/xxxxxxxxxx')"Bad Request" from server, this request might be malformed or not implemented correctly for this vehicle

I couldn't get the root cause of this one, maybe it has something to do with the new token handling?

Yes it seems like some have trouble with this, what car model do you have?
There has been changes to some HTTP headers when authorizing client and fetching data but so far I have only had one report where it has been an issue involving Skoda Citigo.
I myself have a Superb iV and everything is working as expected.
I will backtrace and fix this but need to know of this is an issue for certain models or only certain regions/accounts.

@Farfar
Copy link
Collaborator

Farfar commented Sep 4, 2021

Related to #36

@jfmennedy
Copy link

Hi, the car related to this problem is a Skoda Octavia RS 2019 model with active subscription to skoda online services.

@Farfar
Copy link
Collaborator

Farfar commented Sep 4, 2021

Hi, the car related to this problem is a Skoda Octavia RS 2019 model with active subscription to skoda online services.

Which was latest working release?

@jfmennedy
Copy link

latest working release was 1.0.42

@Farfar
Copy link
Collaborator

Farfar commented Sep 5, 2021

latest working release was 1.0.42

Can you try removing the comment on line 29 of skodaconnect/const.py and then commenting out line 30?
So instead of:

#XCLIENT_ID = '28cd30c6-dee7-4529-a0e6-b1e07ff90b79'
XCLIENT_ID = 'a83d7e44-c8b7-42b7-b8ca-e478270d2091'

You have:

XCLIENT_ID = '28cd30c6-dee7-4529-a0e6-b1e07ff90b79'
#XCLIENT_ID = 'a83d7e44-c8b7-42b7-b8ca-e478270d2091'

@jfmennedy
Copy link

ok, i tried this but still same error.

@Farfar
Copy link
Collaborator

Farfar commented Sep 5, 2021

ok, i tried this but still same error.

I think I've found the problem.
On line 767 in connection.py, change from:

                    self._session_auth_ref_url,

To:

                    self._session_spin_ref_url,

@jfmennedy
Copy link

with this modifiaction it works, even for both clientid

@Farfar
Copy link
Collaborator

Farfar commented Sep 5, 2021

with this modifiaction it works, even for both clientid

Great! Will fix asap.

@Farfar
Copy link
Collaborator

Farfar commented Sep 5, 2021

Fixed in latest commit, scheduled for 1.1.1 release.

@Farfar Farfar closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants