New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme Typo? #5
Comments
Thanks for pointing it out. I originally had named them But forgot to update some part of the doc and just fixed it. Here's the diff: f7f425f |
ok great, sure push pull is more intuitive. however it would be maybe useful for some to describe that "push" includes "other terms commonly used in web and html world like upload etc.." same for "pull" etc... |
Thanks, yeah I agree it would be great if it included more explanation. Feel free to send a PR, the documentation is here https://github.com/skogard/nebulus/blob/main/docs/README.md Otherwise I'll try to add some more details next time I update the repo. |
I think it's better you do it, as I'm pretty new here and you know much better your code than me :) |
You can use the upload event to achieve this:
await nebulus.connect()
nebulus.on("push", (cid) => {
// do something here
})
Because the upload event fires when a CID is successfully found on an IPFS gateway (ipfs.io), you can be sure that it will be pinned for at least a while.
But in your code the event is "push", not "upload", did I miss something?
The text was updated successfully, but these errors were encountered: