Do we handle S3 internal errors correctly?

[henningpeters]

There is a section on internal S3 errors that should result in a retry:

http://docs.aws.amazon.com/AmazonS3/latest/dev/ErrorBestPractices.html

<Error>
<Code>InternalError</Code>
<Message>
We encountered an internal error. Please try again.
</Message>
<RequestId>DE9A32D1F54FC303</RequestId>
<HostId>
nU9Ukaqmsj7gfzQRH+GcnShY9xvsIiKLDY4snrcXa785napfLGHq17Ydh/MZY/Wk
</HostId>
</Error>

Are we already doing that?

[wizzard]

No, we don't retry a request. currently if a request failed (response code != [200, 204, 206]) then we send error back to FUSE level.

[henningpeters]

Looks like 500/503 error codes indicate a transient error and should trigger a retry, see here some discussion and further links to AWS discussion boards:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1590

This is happening more often than one thinks.

[wizzard]

fixed.