Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display url link in object metadata value #52

Closed
olivergg opened this issue Jan 3, 2020 · 3 comments
Closed

Display url link in object metadata value #52

olivergg opened this issue Jan 3, 2020 · 3 comments

Comments

@olivergg
Copy link
Contributor

olivergg commented Jan 3, 2020

The same way it is done in the Kubernetes dashboard (see https://github.com/kubernetes/dashboard/blob/ac31fc56afac27a7ff2f1bc17f050f7403acd844/src/app/frontend/common/components/chips/template.html#L30), we could implement this in k8dash (but in a more efficient way 😉 ).
This can come handy when dealing with annotations that contains URLs.

@herbrandson What do you think ?
@herbrandson
Copy link
Collaborator

I like that, and it looks pretty straight forward. Did you want to take a crack at it?

@olivergg
Copy link
Contributor Author

olivergg commented Jan 4, 2020

@herbrandson Yes 😉 I'll open up a PR

@olivergg
Copy link
Contributor Author

olivergg commented Jan 4, 2020

@herbrandson here is the draft PR : #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herbrandson @olivergg