Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence tests using "malicious" skops files #276

Open
BenjaminBossan opened this issue Jan 23, 2023 · 1 comment
Open

Add persistence tests using "malicious" skops files #276

BenjaminBossan opened this issue Jan 23, 2023 · 1 comment
Assignees
Labels
persistence Secure persistence feature

Comments

@BenjaminBossan
Copy link
Collaborator

We designed the skops persistence format with the intent of being safe against maliciously crafted skops files. Right now, however, there are not tests that explicitly check that loading these kinds of files. Those tests should be added. Of course, nothing actually malicious should happen, but they should serve as a proof of concept.

Ideally, these tests should also help to increase code coverage, as we currently have some uncovered lines that exist as a safeguard against malicious files (see discussion starting here).

@BenjaminBossan BenjaminBossan added the persistence Secure persistence feature label Jan 23, 2023
@E-Aho
Copy link
Collaborator

E-Aho commented Apr 15, 2023

Hey! I'll jump on this, starting to feel a lot better now and I think this would be a good warm up :)

@E-Aho E-Aho self-assigned this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistence Secure persistence feature
Projects
None yet
Development

No branches or pull requests

2 participants