Improve exception message for HasManyThroughAssociationPolymorphicSou…

…rceError Exception message was misleading, as it is possible to have a polymorphic 'has_many :through' join model.
skorfmann · Sep 9, 2012 · 1e554a6 · 1e554a6 · skorfmann · Sep 9, 2012
1 parent f415475
commit 1e554a6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb
@@ -17,7 +17,7 @@ def initialize(owner_class_name, reflection)
 
   class HasManyThroughAssociationPolymorphicSourceError < ActiveRecordError #:nodoc:
     def initialize(owner_class_name, reflection, source_reflection)
-      super("Cannot have a has_many :through association '#{owner_class_name}##{reflection.name}' on the polymorphic object '#{source_reflection.class_name}##{source_reflection.name}'.")
+      super("Cannot have a has_many :through association '#{owner_class_name}##{reflection.name}' on the polymorphic object '#{source_reflection.class_name}##{source_reflection.name}' without 'source_type'. Try adding 'source_type: \"#{reflection.name.to_s.classify}\"' to 'has_many :through' definition.")
     end
   end