Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use createSelectorCreator with reselect-tools #6

Closed
samuelcastro opened this issue Mar 27, 2018 · 5 comments
Closed

How to use createSelectorCreator with reselect-tools #6

samuelcastro opened this issue Mar 27, 2018 · 5 comments
Assignees
Milestone

Comments

@samuelcastro
Copy link

I'm creating a custom selector with my own deep equality check like:

const createDeepEqualSelector = createSelectorCreator(defaultMemoize, equals);

However, it's not clear how to use with with reselect-tools.

@skortchmark9
Copy link
Owner

Hey @samuelcastro - this was a pretty obvious feature but I left it out because I haven't been using it in my codebase. The problem is here. This should default to createSelector and be overridable. For now you can probably just copy it. Don't worry about _allSelectors not being exposed - you can get your selectors into the graph by registering them.

@samuelcastro
Copy link
Author

ok thanks @skortchmark9 I think I will create a fork and implement it, or maybe a PR.

@skortchmark9
Copy link
Owner

In version 4.0.0 of reselect, they'll be adding selector dependencies internally, which will mean we no longer need to shim createSelector. If the shim isn't necessary, we won't have this problem any more.

@skortchmark9 skortchmark9 added this to the 0.0.7 milestone Jul 19, 2018
@skortchmark9 skortchmark9 self-assigned this Jul 19, 2018
@TheBranchDriftCatalyst
Copy link

What is the status of this? I would like to use it but I need createSelectorCreator functionality?

@skortchmark9 skortchmark9 mentioned this issue Oct 20, 2018
2 tasks
@skortchmark9
Copy link
Owner

Fixed in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants