Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new project with API management #105

Closed
skoruba opened this issue Nov 1, 2018 · 12 comments
Closed

Add new project with API management #105

skoruba opened this issue Nov 1, 2018 · 12 comments
Assignees

Comments

@skoruba
Copy link
Owner

skoruba commented Nov 1, 2018

Add new project - Skoruba.IdentityServer4.Admin.Api:

  • Create a list of API controllers - for managing of the IdentityServer4 and Asp.Net Core Identity
  • Add swagger support
@skoruba skoruba added the task Task label Nov 1, 2018
@skoruba skoruba self-assigned this Nov 1, 2018
@ekjuanrejon
Copy link
Contributor

hello @skoruba

any plans on this?

@skoruba
Copy link
Owner Author

skoruba commented Apr 5, 2019

Hi @ekjuanrejon
In the future yes, but if you want to start with this task, feel free send a PR. :)
Thanks!

@skoruba
Copy link
Owner Author

skoruba commented Apr 14, 2019

  • Create projects:
    • Skoruba.IdentityServer4.Admin.Api
    • Skoruba.IdentityServer4.Admin.Api.BusinessLogic - There will be great to reuse the existing repositories (Move repositories to EntityFramework project #250) and create new services for API, including new Dtos etc.

@ekjuanrejon
Copy link
Contributor

@skoruba why can't the business logic of the mvc and the api be shared?

On another note. I see that mvc uses a bit of reflection. Not how how it will play with the api and swagger.

@skoruba
Copy link
Owner Author

skoruba commented Apr 14, 2019

That is great question, I think some of Dtos are very specific for views in MVC app, thefore I am thinking about this separation.
But you are right, maybe it would be fine - create shared business logic layer for both - mvc and api. I will try to consider it.
Good point. :)
Which part of code with reflection do you mean?
Thanks!

@JimBobSquarePants
Copy link

The missing APIs are the only feature that devalues this product from competition. The company I work for are unfortunately having to evaluate another product because we need those APIs and are under so much time pressure we cannot currently dedicate the time to PR the functionality. 😞

👍 on reusing logic.

@skoruba
Copy link
Owner Author

skoruba commented Apr 30, 2019

Thanks for your feedback, I will work on it. :)

@kjbetz
Copy link

kjbetz commented May 1, 2019

I'd like to start taking a look at this and offer some help. I worked on a project for myself that implemented a free UI for the PolicyServer... would be good to implement that all together. I'll start taking a look around of what you have already. Awesome stuff!

@skoruba
Copy link
Owner Author

skoruba commented May 1, 2019

Great, if you want to help, it would be perfect. 👍

@skoruba skoruba pinned this issue May 1, 2019
@skoruba
Copy link
Owner Author

skoruba commented May 6, 2019

I am working on API:
https://github.com/skoruba/IdentityServer4.Admin/tree/feature/api
I am using the shared business logic from MVC project, but with new mapping for API dtos.

Currently still in progress, but with high priority. :)

@skoruba
Copy link
Owner Author

skoruba commented Jun 19, 2019

Done, please take a look at new release. 👍🏼
Thanks.

@skoruba skoruba closed this as completed Jun 21, 2019
@skoruba skoruba unpinned this issue Jun 21, 2019
@JimBobSquarePants
Copy link

Ah fantastic @skoruba ! I'll have a good look asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants