fix(jasmine-globals): fix transform for existing spyOn
#580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
+ Coverage 92.38% 92.63% +0.24%
==========================================
Files 26 27 +1
Lines 1944 2010 +66
Branches 405 416 +11
==========================================
+ Hits 1796 1862 +66
Misses 102 102
Partials 46 46 ☔ View full report in Codecov by Sentry. |
| @@ -42,6 +43,7 @@ test('spyOn', () => { | |||
| jest.spyOn(stuff).mockResolvedValue('lmao'); | |||
| jest.spyOn(stuff).mockRejectedValue('oh no'); | |||
| const fetchSpy = jest.spyOn(window, 'fetch').mockResolvedValue({json: {}}); | |||
| existingSpy; | |||
There was a problem hiding this comment.
This looks wrong to me. Does it make sense to keep it?
There was a problem hiding this comment.
I don't necessarily disagree (more for stylistic reasons than anything technical), but it does match the output of the andCallThrough() transform here.
But now that I'm thinking about it, I wonder if the behavior should be different for existingSpy, as simply dropping the .and.callThrough() wouldn't restore the original implementation. Maybe the more accurate transform would be:
spyOn(stuff).and.callThrough(); -> jest.spyOn(stuff);
existingSpy.and.callThrough(); -> existingSpy.mockRestore();
Thoughts?
There was a problem hiding this comment.
decided to make that change. let me know what you think.
|
thanks @skovhus. would it be possible to publish a new release that contains the recent updates? it doesn't look like there's anything else currently under active development. |
Closes #579
Better handling of usage of
existingSpy.and.callThrough(). This follows the same pattern as the legacyandCallThroughlogic here.