Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsm bin reference #134

Closed
maraisr opened this issue Oct 15, 2021 · 2 comments · Fixed by #141
Closed

Remove tsm bin reference #134

maraisr opened this issue Oct 15, 2021 · 2 comments · Fixed by #141
Labels
good first issue Good for newcomers help wanted Looking for help to reproduce, debug, or open a PR released

Comments

@maraisr
Copy link

maraisr commented Oct 15, 2021

Expected Behavior

"bin": {
"tsm": "./dist/lib/cli.js"
},

read

  "bin": {
-    "tsm": "./dist/lib/cli.js"
+    "typed-scss-modules": "./dist/lib/cli.js"
  },

Current Behavior

"bin": {
"tsm": "./dist/lib/cli.js"
},

Possible Solution

  "bin": {
-    "tsm": "./dist/lib/cli.js"
+    "typed-scss-modules": "./dist/lib/cli.js"
  },

Steps to Reproduce (for bugs)

  • pnpm add tsm
  • pnpm add typed-scss-modules

One "owned" package defining that bin (and rightly so), and typed-scss-modules wanting to overrule that.

Context

When trying to use tsm as a ts-node alt.

Your Environment

  • Version used: 4.1.1
  • Operating System and versions: mac
  • Link to your project: private
@skovy skovy added good first issue Good for newcomers help wanted Looking for help to reproduce, debug, or open a PR labels Jan 2, 2022
@skovy
Copy link
Owner

skovy commented Jan 2, 2022

It seems reasonable as a breaking change to only allow running the CLI via the full package name as proposed to avoid conflicts and improve clarity.

@skovy
Copy link
Owner

skovy commented Jan 31, 2022

🎉 This issue has been resolved in version 4.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@skovy skovy added the released label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for help to reproduce, debug, or open a PR released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants