Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttonClass Prop ignored #18

Closed
rammoozz opened this issue Sep 15, 2015 · 6 comments
Closed

buttonClass Prop ignored #18

rammoozz opened this issue Sep 15, 2015 · 6 comments

Comments

@rammoozz
Copy link
Contributor

buttonClass doesn't seem to do anything.

buttonClass='btn btn-danger'

I set the following as a prop but it doesn't work.

@rammoozz
Copy link
Contributor Author

Thanks for the fix!
👍

@skratchdot
Copy link
Owner

@rkhayat - no problem

@rammoozz
Copy link
Contributor Author

Did this change the buttonText method at all? I was returning options[0].value but after npm update to latest, it is now undefined. I am looking into it now.

@skratchdot
Copy link
Owner

Not sure. The buttonText from the demo still works: http://projects.skratchdot.com/react-bootstrap-multiselect/ but I didn't do much testing...

@rammoozz
Copy link
Contributor Author

No worries, I will continue to test.

@rammoozz
Copy link
Contributor Author

Not sure if related to recent changes, but I had to change options to select in the buttonText method, all is working now.

//was
buttonText = {function(options, select) {
                return this.props.multiSelectTitle + options[0].value + ' <b class="caret"></b>';
            }.bind(this)}     
//is
 buttonText= {function(options, select) {
                return this.props.multiSelectTitle + select[0].value + ' <b class="caret"></b>';
            }.bind(this)}     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants