Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button index should be set dynamically at Neow. #6

Closed
Skrelpoid opened this issue May 28, 2018 · 0 comments
Closed

Fix: Button index should be set dynamically at Neow. #6

Skrelpoid opened this issue May 28, 2018 · 0 comments

Comments

@Skrelpoid
Copy link
Owner

Fix this by setting index of button to size of button list before adding.

Fixes potential issues with other mods that create a Button at Neow and issues if Neow Buttons change
Skrelpoid added a commit that referenced this issue May 31, 2018
@Skrelpoid
v2.1.2
56170ad 
Refactoring and minor bug fixes:
added default cases to switch statements
used explicit variable scoping where needed
use instrument instead of replace patch for AbstractEvent
better code for screenless boss and special relics
button index for neow is now set dynamically

Fixes Issues #1, #2, #3, #4, #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skrelpoid