Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake online player count expression, does not work on paper or paper forks when running Skript 2.7.0+ #6088

Closed
1 task done
KronosCloud opened this issue Oct 2, 2023 · 3 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@KronosCloud
Copy link

Skript/Server Version

[11:35:24 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[11:35:24 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[11:35:24 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[11:35:24 INFO]: [Skript] Server Version: git-Purpur-2062 (MC: 1.20.1)
[11:35:24 INFO]: [Skript] Skript Version: 2.7.1 (skriptlang-github)
[11:35:24 INFO]: [Skript] Installed Skript Addons:
[11:35:24 INFO]: [Skript]  - skript-reflect v2.3.1-for-Skript-2.7 (https://github.com/TPGamesNL/skript-reflect)
[11:35:24 INFO]: [Skript]  - SkriptJSON v1.0.0
[11:35:24 INFO]: [Skript]  - SkBee v2.18.3 (https://github.com/ShaneBeee/SkBee)
[11:35:24 INFO]: [Skript] Installed dependencies:
[11:35:24 INFO]: [Skript]  - WorldGuard v7.0.9+5934e49

Bug Description

the fake online player count expression, does not work on paper or paper forks when running Skript 2.7.0+

Expected Behavior

this epxression to work as intended and properly check which event is being used

Steps to Reproduce

Option 1 if you have reflect use

on server list ping:
  broadcast event

else use

on server list ping:
  set fake player count to 100

Errors or Screenshots

javaw_2NvrMa0gfH

Other

mention it's trying to compare against StandardPaperServerListPingEventImp

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@UnderscoreTud UnderscoreTud added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Oct 2, 2023
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Oct 2, 2023

Most likely due to the change in how isCurrentEvent worked before, the check should be reversed (paper check first)

@Fusezion
Copy link
Contributor

Fusezion commented Oct 2, 2023

I'm still confused why the event class is StandardPaperServerListPingEventImp tho, since the order shouldn't be causing any issue with that afaik

@AyhamAl-Ali AyhamAl-Ali self-assigned this Oct 2, 2023
@AyhamAl-Ali
Copy link
Member

I'm still confused why the event class is StandardPaperServerListPingEventImp tho, since the order shouldn't be causing any issue with that afaik

nvm about reversing, just adding !PAPER_EVENT_EXISTS anded with first condition should fix it

@AyhamAl-Ali AyhamAl-Ali added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

5 participants