Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliases.load() takes to long -> Paper kills server #6179

Open
1 task done
DerMistkaefer opened this issue Nov 8, 2023 · 1 comment
Open
1 task done

Aliases.load() takes to long -> Paper kills server #6179

DerMistkaefer opened this issue Nov 8, 2023 · 1 comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@DerMistkaefer
Copy link

Skript/Server Version

[20:14:05 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[20:14:05 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[20:14:05 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[20:14:05 INFO]: [Skript] Server Version: git-Paper-196 (MC: 1.20.1)
[20:14:05 INFO]: [Skript] Skript Version: 2.7.2 (skriptlang-github)
[20:14:05 INFO]: [Skript] Installed Skript Addons: None
[20:14:05 INFO]: [Skript] Installed dependencies: None

Bug Description

The Aliases.load() in the Skript Plugin onEnable() takes to long and so Paper kills the server.
The Server is run in an docker environement with limited cpu and we also increased the Paper Watchdog time, but the Aliases.load takes 40 seconds. It's increased with the new aliases from 1.20.2.

Expected Behavior

The Aliases.load() should be called in an Background Task like:
Bukkit.getScheduler().runTask(plugin, () -> {
Aliases.load()
// rest from the onEnable function
});

Steps to Reproduce

Start a server with Skript on an machine with less CPU or in a docker environment with limited CPU.

Errors or Screenshots

[18:59:34] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH  - git-Paper-196 (MC: 1.20.1) ---
[18:59:34] [Paper Watchdog Thread/ERROR]: The server has not responded for 35 seconds! Creating thread dump
[18:59:34] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:59:34] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[18:59:34] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:59:34] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[18:59:34] [Paper Watchdog Thread/ERROR]: 	PID: 26 | Suspended: false | Native: false | State: RUNNABLE
[18:59:34] [Paper Watchdog Thread/ERROR]: 	Stack:
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.HashMap.putMapEntries(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.HashMap.putAll(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.persistence.CraftPersistentDataContainer.<init>(CraftPersistentDataContainer.java:26)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.inventory.CraftMetaItem.clone(CraftMetaItem.java:1399)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.inventory.CraftMetaArmor.clone(CraftMetaArmor.java:181)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.inventory.CraftMetaArmor.clone(CraftMetaArmor.java:19)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.ItemData.compareItemMetas(ItemData.java:419)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.ItemData.matchAlias(ItemData.java:346)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.AliasesMap.exactMatch(AliasesMap.java:215)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.AliasesProvider.addAlias(AliasesProvider.java:294)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.AliasesParser.loadSingleAlias(AliasesParser.java:694)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.AliasesParser.loadAlias(AliasesParser.java:603)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.AliasesParser.load(AliasesParser.java:121)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.load(Aliases.java:504)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.load(Aliases.java:490)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.lambda$loadDirectory$1(Aliases.java:473)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases$$Lambda$7010/0x00007f2b21594438.accept(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.SortedOps$RefSortingSink$$Lambda$687/0x00007f2b2025c618.accept(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.ArrayList.forEach(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.SortedOps$RefSortingSink.end(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.util.stream.ReferencePipeline.forEach(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.loadDirectory(Aliases.java:466)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.loadInternal(Aliases.java:431)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.aliases.Aliases.load(Aliases.java:387)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		Skript.jar//ch.njol.skript.Skript.onEnable(Skript.java:506)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:281)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:189)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		realms-spigot-core-plugin-0.1.jar//de.cytooxien.realms.spigot.core.plugin.RealmPluginManager.enablePlugin(RealmPluginManager.java:522)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		realms-spigot-core-plugin-0.1.jar//de.cytooxien.realms.spigot.core.RealmsPluginsLoader.loadUserPlugins(RealmsPluginsLoader.java:71)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		realms-spigot-core-plugin-0.1.jar//de.cytooxien.realms.spigot.core.RealmsCorePlugin.afterFetchRealmInfo(RealmsCorePlugin.java:420)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		realms-spigot-core-plugin-0.1.jar//de.cytooxien.realms.spigot.core.RealmsCorePlugin$$Lambda$6077/0x00007f2b2141c1a8.run(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1479)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1393)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1170)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		net.minecraft.server.MinecraftServer$$Lambda$4850/0x00007f2b20b674b8.run(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.8.1/java.lang.Thread.run(Unknown Source)
[18:59:34] [Paper Watchdog Thread/ERROR]: ------------------------------
[18:59:34] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---
[18:59:34] [Paper Watchdog Thread/ERROR]: ------------------------------`

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Nov 10, 2023
@TheLimeGlass
Copy link
Collaborator

Increase the timeout-time configuration in the spigot.yml to compensate for the server being forced to run at lower performance.

@sovdeeth sovdeeth mentioned this issue Feb 2, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sovdeeth @DerMistkaefer @TheLimeGlass