Skript on (Ketting) 1.20.1 #6351
Labels
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
completed
The issue has been fully resolved and the change will be in the next Skript update.
good first issue
An issue that would be good for a first-time contributor to make a PR for
priority: lowest
"Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Skript/Server Version
Bug Description
Skript/src/main/java/ch/njol/skript/Skript.java
Line 1160 in b9f89c1
MinecraftServer.isRunning()
.Instead it points to
MinecraftServer.getLocalIp()
, which results in an error, when callingSkript.isServerRunning()
, becauseIS_RUNNING.invoke(MC_SERVER)
returns ajava.lang.String
, not aboolean
.This is because Minecraft's 1.20.1 mangled name for
MinecraftServer.isRunning
is back tov
.Expected Behavior
The plugin shuts down cleanly, without needing to provide
boolean isStopping();
inorg.bukkit.Server
.Steps to Reproduce
Build ketting and remove the
boolean isStopping();
method inorg.bukkit.Server
.Put Skript into the plugin folder.
Run and stop the server.
Observe an error whilst shutting the Server down.
Errors or Screenshots
No response
Other
(yeah, this shows 2.7.3, but I also validated, that this happens on 2.8.0)
Agreement
The text was updated successfully, but these errors were encountered: