Pluralize the :topic initialization option #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragoulis
force-pushed
the
plural-topics
branch
2 times, most recently
from
dbcd6c9
to
eb2a030
Compare
lib/rafka/consumer.rb
Outdated
| @@ -199,11 +199,17 @@ def commit(*msgs) | |||
| # @return [Array<Hash, Hash>] rafka opts, redis opts | |||
| def parse_opts(opts) | |||
| REQUIRED_OPTS.each do |opt| | |||
| raise "#{opt.inspect} option not provided" if opts[opt].nil? | |||
| raise "#{opt.inspect} option not provided" if opts[opt].nil? || opt[opt].empty? | |||
There was a problem hiding this comment.
Shouldn't this be opts[opt].empty?
By default, kafka and kafka-go support consumers subscribing to multiple topics, by passing an array of strings. Rafka also respects this (see server.go#parseTopicsAndConfig). Rafka-rb simply needs to change the wording in order to respect the plural and in effect show the api user that consuming from multiple topics is supported. The commit takes the extra step of supporting an array of strings as well as a single string, whether it contains a single topic or multiple comma-separated topics. Closes #5
fragoulis
force-pushed
the
plural-topics
branch
from
eb2a030
to
78ae428
Compare
agis
reviewed
Apr 18, 2019
Support both topic & topics ? or just topic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.
Rafka also respects this.
Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.
The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.
Closes #5