Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divided caches to api and implementation #8

Closed
wants to merge 1 commit into from
Closed

Divided caches to api and implementation #8

wants to merge 1 commit into from

Conversation

zTrap
Copy link

@zTrap zTrap commented Apr 4, 2023

Fixes #7

@zTrap zTrap requested a review from sksamuel as a code owner April 4, 2023 12:25
@zTrap zTrap mentioned this pull request Apr 4, 2023
@sksamuel
Copy link
Owner

Can we think of a better name than wrapper, I thought the old names were fine.
Maybe create a new package if we want to reuse them.

@zTrap
Copy link
Author

zTrap commented Apr 10, 2023

Yes I dont like to use *wrapper in names either, but the old names are clashing with original lib classes and can be imported by mistake. Also the actual functionality of these classes isn't caching, they do (un-)wrapping and (down/up-)streaming, so the old names isn't represent what they do.

As an option I can suggest to use *facade instead of *wrapper.

@turboezh
Copy link

turboezh commented May 7, 2023

Hi. Imho, it's looks more like adapter rather than facade. I can suggest something like (Coroutine)CacheAdapter.

@zTrap zTrap closed this Feb 12, 2024
@zTrap zTrap deleted the feature/divide-api-and-implementation branch February 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide cache wrappers to api and implementation
3 participants