Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

97 custom inspections #114

Conversation

RichardBradley
Copy link
Contributor

This implements #97.

See corresponding changes in sbt-scapegoat.

(I haven't written any tests, as it's not very amenable to unit testing.)

@RichardBradley
Copy link
Contributor Author

This is now working and tested -- see https://github.com/RichardBradley/scapegoat-custom-inspection-subproject-example

@RichardBradley
Copy link
Contributor Author

(I can't repro that build failure. The tests all pass for me, on a linux box)

I can now -- it seems like the tests fail the first time they are run on a clean box (I don't think this is new though). I'm fixing.

I think it's scala 2.11.6 vs scala 2.11.7 somehow -- maybe a new release?

-- Yes, in commit 88c13b3 you changed scala version in build.sbt but not in PluginRunner. This will break the tests on the CI server or other machines without a cached copy of scala 2.11.6

@RichardBradley
Copy link
Contributor Author

Actually, it might be safest to hold off merging this and scapegoat-scala/sbt-scapegoat#27 until I can do some more testing.

Some simple test projects which are included in this PR in src/sbt-test work fine, but I get weird class version incompatibility errors when I try to use this on a big real-world multi-module SBT project.

I'll update here when I have more info.

@sksamuel sksamuel closed this Jun 18, 2019
@RichardBradley
Copy link
Contributor Author

Sorry that I haven't managed to finalise this. I haven't been using Scala for a couple of years.
The "big real-world multi-module SBT project" is finished.
I will re-open if I get a chance to tidy this up (but don't hold your breath).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants