Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add trailing slashes #173

Open
fleimgruber opened this issue Jan 15, 2024 · 1 comment
Open

Option to add trailing slashes #173

fleimgruber opened this issue Jan 15, 2024 · 1 comment

Comments

@fleimgruber
Copy link

fleimgruber commented Jan 15, 2024

As a user, I want to add trailing slashes to requests. I found

add_trailing_slash: bool = False,
but no way to set this kwarg.

Related #136 talks about follow_redirects but that did not work for me.

@skshetry
Copy link
Owner

Does a link without trailing slash redirect to a url with a slash? iirc if it does, it should work (I see we do follow_redirects=True on propfind).

We strip trailing slashes in many places, so that's what causes the problem in many places. Unfortunately, I don't have time anytime soon to work on this. PRs are welcome.
(We also need to look into WebDAV standard for compliance with what the link format should be (canonical or not, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants