Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Class contraction #31

Open
fkiraly opened this issue Jul 28, 2022 · 2 comments
Open

[ENH] Class contraction #31

fkiraly opened this issue Jul 28, 2022 · 2 comments
Labels
API design API design & software architecture feature request New feature or request

Comments

@fkiraly
Copy link
Contributor

fkiraly commented Jul 28, 2022

Not an immediate next step, but it would be great to have the feature of "contraction".

This is a function which takes a composite class and turns it into a non-composite class.
Parameters from the components are all mapped onto parameters of the result.

Example:
if input has get_params().keys() output ["component1", "component1_foo", "component2", "component2_bar", "foobar"], after contraction this should become ["foo", "bar", "foobar"], without any functional difference to the objects in question. In the "contracted" class, the components are hard-coded (whereas in the composite they may not have been).

@fkiraly fkiraly added the feature request New feature or request label Jul 28, 2022
@ramcharanmedipally
Copy link

Hi there,
This is Avinash Kumar Dubey, I'm new on GitHub and want to contribute to OpenSource to make my Account robust.

I can add this contraction feature but I've some questions like where I should do the code for this and how this feature will work. for example,

list = ["component1", "component1_foo", "component2", "component2_bar", "foobar"]

method 1:
contraction(list)

method 2:
list.contraction()

@fkiraly
Copy link
Contributor Author

fkiraly commented Nov 22, 2022

Hello @ramcharanmedipally!

Apologies, I did not see your post earlier since this repo is currently still in early design stage, and we didn't monitor this repo for new contributor posts.

This is not about list contraction but class contraction - apologies.

How about you look for interesting good first issues on sktime?
https://www.github.com/alan-turing-institute/sktime

Sorry again for not responding.

@RNKuhns RNKuhns changed the title feature: contraction [ENH] Class contraction Jan 8, 2023
@RNKuhns RNKuhns added the API design API design & software architecture label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design API design & software architecture feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants