Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] conda release - compatibility with Python 3.12 #330

Closed
MCRE-BE opened this issue May 15, 2024 · 13 comments
Closed

[MNT] conda release - compatibility with Python 3.12 #330

MCRE-BE opened this issue May 15, 2024 · 13 comments
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@MCRE-BE
Copy link

MCRE-BE commented May 15, 2024

Desbribe the issue

Quick question, is scikit-base really compatible with Python 3.12 ? Or is this one of the issues you mention with scikit-base and conda releases being "under development"
Under conda and mamba I cannot update to 3.12 (either because of SKTime, but likely because of the dependency on scikit-base).

(base) C:\WINDOWS\system32>conda create -n New python==3.12.3 scikit-base
Channels:
 - conda-forge
 - defaults
Platform: win-64
Collecting package metadata (repodata.json): done
Solving environment: - warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
\ warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
warning  libmamba Problem type not implemented SOLVER_RULE_STRICT_REPO_PRIORITY
failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package scikit-base-0.4.3-py310hbbfc1a7_0 requires python_abi 3.10.* *_cp310, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ python 3.12.3  is installable with the potential options
│  ├─ python 3.12.3 would require
│  │  └─ python_abi 3.12.* *_cp312, which can be installed;
│  └─ python 3.12.3 conflicts with any installable versions previously reported;
└─ scikit-base is not installable because there are no viable options
   ├─ scikit-base [0.4.3|0.4.4|...|0.7.8] would require
   │  └─ python_abi 3.10.* *_cp310, which conflicts with any installable versions previously reported;
   ├─ scikit-base [0.4.3|0.4.4|...|0.7.8] would require
   │  └─ python_abi 3.11.* *_cp311, which conflicts with any installable versions previously reported;
   ├─ scikit-base [0.4.3|0.4.4|...|0.7.8] would require
   │  └─ python_abi 3.8.* *_cp38, which conflicts with any installable versions previously reported;
   └─ scikit-base [0.4.3|0.4.4|...|0.7.8] would require
      └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported.
@fkiraly
Copy link
Contributor

fkiraly commented May 15, 2024

Thanks for reporting!

Indeed it seems this has not been properly updated in the conda recipe.

That explains the low download numbers, we have wondered why they are so much lower on conda.

With pip, there should be no problems though.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label May 15, 2024
@fkiraly
Copy link
Contributor

fkiraly commented May 15, 2024

Attempted fix:
conda-forge/skbase-suite-feedstock#49

You wouldn't perhaps know what is going on with numpy there, in the CI jobs?

@fkiraly fkiraly changed the title [QUESTION] Compatibility with Python 3.12 [MNT] conda release - compatibility with Python 3.12 May 16, 2024
@fkiraly
Copy link
Contributor

fkiraly commented May 16, 2024

Something is going on here, here's a new PR on the sktime conda feedstock, this was not triggered by us - FYI @yarnabrina, what is this? conda-forge/sktime-feedstock#123

@fkiraly
Copy link
Contributor

fkiraly commented May 16, 2024

Also summoning @dhirschfeld, @freddyaboulton - any idea what is going on here?

@yarnabrina
Copy link
Contributor

Something is going on here, here's a new PR on the sktime conda feedstock, this was not triggered by us - FYI @yarnabrina, what is this? conda-forge/sktime-feedstock#123

I do not know. Can we ask help from conda forge maintainers who helped during previous release? I forgot their Github handle.

@fkiraly
Copy link
Contributor

fkiraly commented May 17, 2024

@beckermr, @mbargull, may I kindly ping you on this, since we seem to be out of our depth.

To summarize the history of this discussion:

@dhirschfeld
Copy link

@fkiraly
Copy link
Contributor

fkiraly commented May 18, 2024

Ah, thanks!
Did not see this because on a closed PR.

I think scikit-base could be noarch: python which would resolve this issue.

You'd need to put in a PR adding noarch: python to all build sections, removing all cross-python_ lines and all comment selectors (and then rerender).

Shall we try this?

I can make the PR, but I thought maybe you want the honour so the fix is in the record with your name, @dhirschfeld.

@dhirschfeld
Copy link

I won't have time to put in a PR, but might be able to review it.

@fkiraly
Copy link
Contributor

fkiraly commented May 18, 2024

Sure - first attempt:
conda-forge/skbase-suite-feedstock#52
FYI @dhirschfeld

@MCRE-BE
Copy link
Author

MCRE-BE commented May 23, 2024

Can be closed now no?

@fkiraly
Copy link
Contributor

fkiraly commented May 24, 2024

I would say, let's keep it open until the next release has gone through. Only then we will know that this has been solved without problems...

@fkiraly
Copy link
Contributor

fkiraly commented May 26, 2024

looks like all is fine. Thanks for your help, @dhirschfeld, @MCRE-BE!

Reference: conda-forge/skbase-suite-feedstock#66

@fkiraly fkiraly closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

4 participants