Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] interface XGBoostLSS et al by StatMixedML #184

Open
4 tasks
fkiraly opened this issue Jan 26, 2024 · 6 comments
Open
4 tasks

[ENH] interface XGBoostLSS et al by StatMixedML #184

fkiraly opened this issue Jan 26, 2024 · 6 comments
Labels
feature request New feature or request interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:regression probabilistic regression module

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 26, 2024

It would be great to interface the various probabilistic supervised regressors of StatMixedML, so they can then immediately used for forecasting in sktime via skpro!

FYI @StatMixedML, @joshdunnlime

Many thanks to @KiwiAthlete for the suggestion!

@fkiraly fkiraly added module:regression probabilistic regression module interfacing algorithms Interfacing existing algorithms/estimators from third party packages feature request New feature or request labels Jan 26, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 26, 2024

PS @StatMixedML, I notice that you are interested in probabilistic forecasting, yet the estimators provided are, strictly speaking, probabilistic tabular regressors. That's not a big problem, as skpro is integrated with the most common reduction compositors in sktime, so any skpro regressor can be directly used to create probabilistic forecasters via make_reduction etc.

What would be nice, with your expertise, is some thinking around uncertainty estimates in recursive regression, that seems non-obvious. Let us know if you are interested in some methology research around that - or if you already have some solutions 😄

@StatMixedML
Copy link

@fkiraly Thanks for suggesting the skpro integration. Integrating the LSS-models into both skpro and sktime would be a fantastic extension! For now I suggest we focus on the XGBoostLSS/LightGBMLSS integrations, since the other two LSS frameworks are currently not maintained.

PS @StatMixedML, I notice that you are interested in probabilistic forecasting, yet the estimators provided are, strictly speaking, probabilistic tabular regressors.

That is correct. General purpose tree models are, without using parametric models in the leaf-nodes, not designed for forecasting, since they lack the ability to extrapolate beyond the training data. However, using the linear_tree option in LightGBMLSS, gets us around this problem.

What would be nice, with your expertise, is some thinking around uncertainty estimates in recursive regression, that seems non-obvious. Let us know if you are interested in some methology research around that - or if you already have some solutions.

That sounds like an interesting problem. Can you maybe sketch the problem in more detail. We can also have the discussion via email if you want.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 27, 2024

That sounds like an interesting problem. Can you maybe sketch the problem in more detail.

Sure! Done in this discussion thread:
#185
Let me know if it makes sense, or if not, or if you would simply like more explanation.

We can also have the discussion via email if you want.

I know how academics are, so thanks for being considerate in this respect.
I think though, it's hard to argue precedence with public GitHub history. Of course, this could be disregarded or not mentioned (I have seen that a couple times), but the same can happen to any paper.

Hence I do not mind the discussion in public, even if novel methodological content comes out of it.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 27, 2024

Integrating the LSS-models into both skpro and sktime would be a fantastic extension! For now I suggest we focus on the XGBoostLSS/LightGBMLSS integrations, since the other two LSS frameworks are currently not maintained.

Thanks for your support! Let's get to it then 😃, contributions appreciated.

@StatMixedML
Copy link

StatMixedML commented Jan 28, 2024

I have created respective branches in the repos

Please work towards them before we actually merge it to master.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 28, 2024

hm, @StatMixedML, are you planning to write the estimator directly in the respective package?
Sure, that works - if you want to test it there, you can use check_estimator from skpro.utils.

Though for that set-up, you may like to consider relaxing your depedency bounds? See discussion in StatMixedML/XGBoostLSS#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:regression probabilistic regression module
Projects
None yet
Development

No branches or pull requests

2 participants