Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples notebooks to support sktime 0.4.1 #66

Closed
Withington opened this issue Aug 13, 2020 · 2 comments
Closed

Update examples notebooks to support sktime 0.4.1 #66

Withington opened this issue Aug 13, 2020 · 2 comments
Assignees
@Withington
Labels
bug Something isn't working

Comments

@Withington
Copy link
Collaborator

Describe the bug
examples/*ipynb are not working in dev branch with sktime 0.4.1
@Withington Withington added the bug Something isn't working label Aug 13, 2020
@Withington Withington self-assigned this Aug 13, 2020
@Withington
Copy link
Collaborator Author

@mloning Is sktime Tabularizer working correctly? This fails Xt = Tabularizer().transform(X) with This instance of Tabularizer has not been fitted yet; please call fit first.

@mloning
Copy link
Contributor

mloning commented Aug 13, 2020

It should be

Xt = Tabularizer().fit_transform(X)

We follow scikit-learn's logic where you have to call fit first (even if fit basically doesn't do anything as in this case)

@Withington Withington mentioned this issue Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Withington Withington

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mloning @Withington