Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing Forecasters to be Refactored #1007

Closed
2 of 15 tasks
thayeylolu opened this issue Jun 21, 2021 · 3 comments
Closed
2 of 15 tasks

Listing Forecasters to be Refactored #1007

thayeylolu opened this issue Jun 21, 2021 · 3 comments

Comments

@thayeylolu
Copy link
Collaborator

#955
We need to slowly re-factor all forecasters to be compliant with the new interface (see PR #912). i.e., no overrides of fit etc and descendant classes only implementing core logic, while the BaseForecaster implements check etc logic.

Currently this is running due to various downwards compatibility workarounds, which should be removed once all forecasters are ready (in "no-override" state)

The forecasters that still need a downstream refactor are:

  • Forecasters in Italic text are failing test or CI

  • Forecasters checked have been merged

  • Forecasters in Bold text are in progress and have not been merged

  • NaiveForecasters

  • EnsembleForecaster

  • MultiplexForecaster

  • TransformedTargetForecaster

  • _Reducer and related code

  • StackingForecaster

  • ForecastingGridSearchCV, RandomizedGridSearchCV, and BaseGridSearch

  • OnlineEnsembleForecaster and descendants

  • _PmdArimaAdapter and descendants ARIMA, AutoARIMA

  • BATS, TBATS, and _Tbatsadapter

  • _StatsModelAdapter and descendants AutoETS, ExponentialSmoothing, ThetaForecaster

  • HCrystalBallForecaster

  • Prophet and _ProphetAdapter

  • PolynomialTrendForecaster

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 21, 2021

this is a duplicate of #955.

@fkiraly fkiraly closed this as completed Jun 21, 2021
@Lovkush-A
Copy link
Collaborator

Lovkush-A commented Jun 21, 2021

@fkiraly @thayeylolu I think Taiwo created this because we can't edit Franz's checkboxes in #955. (at least, I know that I cannot adjust them).

To get around this, I created checkboxes in the hackmd file for forecasting group of 2021 dev days. https://hackmd.io/84rpzQEiQiWQy5oQjs7FYw?view. The checkboxes are at the bottom of the hackmd file

It this is not a suitable solution, let me know

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 21, 2021

ah - well, I can simply update the checkboxes whenever a PR related to the root issue is closed?

Because I'd be reviewing them anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants